PushNotificationIOS conflicting docs AND localNotification event is not firing after remote notif SDK integration

[rgomezp]

React Native version:

    System:
    OS: macOS 10.14.6
    CPU: (8) x64 Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz
    Memory: 453.62 MB / 16.00 GB
    Shell: 5.3 - /bin/zsh
  Binaries:
    Node: 10.15.0 - /usr/local/bin/node
    Yarn: 1.12.3 - /usr/local/bin/yarn
    npm: 6.9.0 - /usr/local/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  SDKs:
    iOS SDK:
      Platforms: iOS 12.4, macOS 10.14, tvOS 12.4, watchOS 5.3
    Android SDK:
      API Levels: 24, 26, 27, 28, 29
      Build Tools: 26.0.2, 27.0.3, 28.0.3, 29.0.0
      System Images: android-27 | Google Play Intel x86 Atom, android-28 | Google Play Intel x86 Atom
      Android NDK: 14.1.3816874
  IDEs:
    Android Studio: 3.4 AI-183.6156.11.34.5522156
    Xcode: 10.3/10G8 - /usr/bin/xcodebuild
  npmPackages:
    react: 16.9.0 => 16.9.0
    react-native: 0.60.5 => 0.60.5
  npmGlobalPackages:
    create-react-native-app: 2.0.2
    react-native-cli: 2.0.1

Steps To Reproduce

1. git clone git@github.com:geektimecoil/react-native-onesignal
2. cd react-native-onesignal/examples/RNOneSignal/
3. git checkout reproduce-local-notif-conflict (branch with local notif repro code)
4. yarn
5. Build and run the example app by:
   • Open the RNOneSignal project in XCode
   • Change the Signing Team and Bundle Identifier for both the RNOneSignal target as well as the OneSignalNotificationServiceExtension
     • The Service Extension bundle id should be <main-target-bunde-id>.OneSignalNotificationServiceExtension

Your AppDelegate.m should look like this after following the OneSignal (remote notifications) setup instructions and the PushNotificationIOS (local notifications) setup instructions.

One thing to note is that it seems like the PushNotificationIOS docs have conflicting instructions...which brings me to the first issue:

Part 1:
The code in those docs says to add this to your AppDelegate.m:

 // Required for the localNotification event.
 - (void)application:(UIApplication *)application didReceiveLocalNotification:(UILocalNotification *)notification
 {
  [RCTPushNotificationManager didReceiveLocalNotification:notification];
 }

However, it also says to add

// Define UNUserNotificationCenter
  UNUserNotificationCenter *center = [UNUserNotificationCenter currentNotificationCenter];
  center.delegate = self;

which in theory should break the former. It would be nice to clarify this discrepancy.

Part 2:
After adding the OneSignal SDK (remote notifications), the event listener for localNotification no longer is triggered.

In the OneSignal example app you built in the reproduction steps, tap "Send Local Notifs". You will see in the console that the console.log in the localNotification handler is never fired after tapping on the local notification.

This may be an issue on our side (OneSignal). However, it isn't clear to us why this is happening and the documentation isn't clear on how to properly handle both the old (deprecated) and new ways of handling local notifications.

A better local notification click handler would use userNotificationCenter:didReceiveNotificationResponse:withCompletionHandler so we would love to see this used in a future RN version (Apple docs). This would be the only way to solve the compatibility issue between plugins for the click handler for iOS 10+ devices.

[react-native-bot]

It looks like you are using an older version of React Native. Please update to the latest release, v0.60 and verify if the issue still exists.

The "Resolution: Old Version" label will be removed automatically once you edit your original post with the results of running `react-native info` on a project using the latest release.

[stale]

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

[rgomezp]

This issue still hasn't been fixed

[stale]

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

[rgomezp]

Still not fixed

[rgomezp]

Any update on this?

[garydevenay]

Also still looking for an update on this.

[rgomezp]

Any update from the React Native team?

[maddy16]

Still not fixed. Any update from React Native???

[carloscuesta]

The docs for the AppDelegate.m part are confusing, as @rgomezp says didReceiveLocalNotification method should not be referenced anymore in the docs since its deprecated and should be be replaced by this, right ?

[safaiyeh]

@carloscuesta thanks for the investigation. Could you make this change in the docs? https://github.com/facebook/react-native-website. They merge updates in fairly quickly.

Is this just a docs issue or is there actual buggy code that needs to be addressed?

[carloscuesta]

Sure I can make the PR! However I'm not 100% sure that my assumption is correct.

According to iOS docs -> https://developer.apple.com/documentation/uikit/uiapplicationdelegate/1622930-application?language=objc

The following method application:didReceiveLocalNotification is deprecated and this one should be used:

Use userNotificationCenter:willPresentNotification:withCompletionHandler: instead.

The first part of this issue is related to documentation but seems that there's a second part which involves a bug on code as @rgomezp says

[safaiyeh]

@carloscuesta yeah that looks right. React Native targets iOS 11 so that should be changed. Would be nice to confirm it works locally by providing a repo with your react-native-website PR.

Make sure to tag this issue as well with the docs change!

[Simek]

@safaiyeh React Native didReceiveLocalNotification method is still present in the code, can we remove it from the library first before removing it from the docs? 🙂

Also it looks like that RNTester is also using that handler (I'm not sure if there is a test related to that):

• https://github.com/facebook/react-native/blob/master/packages/rn-tester/RNTester/AppDelegate.mm#L252

---

The @react-native-community/push-notification-ios team fixed the local notification issue for new iOS releases in this PR (hope this will shed some more light into the problem):

• Handling local notification event for IOS 10+ react-native-push-notification/ios#104

[stale]

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

[rgomezp]

This issue shouldn't be closed I don't think. There needs to be a code change and then a documentation change. What is this status of this effort?

[github-actions]

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[github-actions]

This issue was closed because it has been stalled for 7 days with no activity.