fixed wrong path on install script - #22703

[thisisablock]

Summary

On installing Pods on Mac OS, the script fails on downloading the dependencies.

cd "$dir"
eval "${cmd:-true}" && touch .installed)

will fail, because the workdir is wrong here.
cd "$dir" is accessing the extracted folder of the source but the script call on

fetch_and_unpack glog-0.3.5.tar.gz https://github.com/google/glog/archive/v0.3.5.tar.gz 61067502c5f9769d111ea1ee3f74e6ddf0a5f9cc "\"$SCRIPTDIR/ios-configure-glog.sh\""

is referencing on ./ios-configure-glog.sh

this is fixing the 'glog/logging.h' file not found error on build.
on the most users the error will not occur, because glog was compiled before
or the ~/.rncache already has all files.

Changelog

• changed relative path to a correct absolute to fix non fetching third-party libs on pod install

iOS Changed - pod build script for third party libs

Test Plan

• clone fresh repo
• install node dependencies
• pod install (to fetch glog, etc.)
• build

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[pull-bot]

Messages

📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message. CATEGORY may be: General iOS Android JavaScript Internal (for changes that do not need to be called out in the release notes) TYPE may be: Added, for new features. Changed, for changes in existing functionality. Deprecated, for soon-to-be removed features. Removed, for now removed features. Fixed, for any bug fixes. Security, in case of vulnerabilities. MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 5543c4d

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[cpojer]

I don't think pwd is a good idea because it's where the script was invoked from but this script wants to have the directory of the scripts folder itself so I don't think that's the correct fix. I'm struggling to understand your summary. Could you explain the problem and the before and after state with your fix applied? That way I can try to reproduce this myself and confirm the fix is working.

[alloy]

I just came across this PR while digging through the history of this script. This script was removed in #27810, so going to close this now. Thanks for the contribution, though!