-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix broken unit test #682
Conversation
Signed-off-by: Mike Murray <hellomikemurray@gmail.com>
Signed-off-by: Mike Murray <hellomikemurray@gmail.com>
Signed-off-by: Mike Murray <hellomikemurray@gmail.com>
Signed-off-by: Mike Murray <hellomikemurray@gmail.com>
Fixed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I wonder which of the tests rely on babel? I removed the customized babel config on purpouse as it is not required anymore. If tests really rely on it, maybe we could find a way so it is not picked up by nextjs? Or do you want to include a custom babel config either way? |
@janus-reith there are only a few unit test that are running:
10 to be exact, if we can get those to pass without adding the config in this PR, that would be great. |
@willopez Thanks, I also realized after taking another look which ones were meant. I just looked at the nextjs with-jest example: https://github.com/vercel/next.js/tree/canary/examples/with-jest |
Resolves #681
Impact: critical
Type: test
Issue
tests are failing
Solution
Breaking changes
none
Testing