-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: runtime build issues #685
Conversation
Signed-off-by: Mike Murray <hellomikemurray@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mikemurray The babel config I made obsolete for the new version was added back in #682, introducing this error. I don't see us using specific features that would make it reasonable to introduce potential upstream issues by diverging from the nextjs defaults here. |
@janus-reith just saw your comment, after I approved it. I am open to removing it and simplifying the config. PR welcomed. |
@willopez Yes, I would prefer if we discuss in #683 or some seperate issue instead how to approach the tests cleanly, and which should be there in general.( I think @HarisSpahija also wanted to contribute to that.) The previous storefront version also had a bunch of babel dependencies I'd rather not have included here again. TBH my preference would be to revert #682 and not merge this one, and fix the tests instead. |
Sounds good, lets discuss on #682 |
Signed-off-by: Mike Murray <hellomikemurray@gmail.com>
This PR removes unnecessary babel config and some dependencies. A new PR will be created to remove snapshot test and related dependencies add react testing library and cypress. See for more context: #683 (comment) |
Issue
Cannot run app due to regenerator runtime issues
Solution
Update babel config
Breaking changes
none
Testing