Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: use new Catalyst data table in products view and update orders view #182

Merged
merged 32 commits into from
Jan 29, 2020
Merged

Feature: use new Catalyst data table in products view and update orders view #182

merged 32 commits into from
Jan 29, 2020

Conversation

willopez
Copy link
Member

@willopez willopez commented Jan 14, 2020 •
edited
Loading

Resolves #181
Impact: major
Type: refactor

Summary

This PR integrates the new DataTable from the Reaction Catalyst design system in the products view. As a side effect, many Meteor method dependencies will be removed.

Breaking changes

None

Testing

  1. Verify all bulk actions in the products view work as intended, paying attention to success/error notifications for correctness.
  2. This PR also adds a couple of filters to the orders table, verify all filters work as intended.
  3. Verify all unnecessary Meteor publications have been removed.

@willopez
fix: invalid component prop
35721f6 
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@willopez
feature: WIP use Catalyst DataTable for products view
956258d 
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@willopez
Merge branch 'trunk' into feature-use-new-data-table-in-products-view
5cc3291
@willopez
refactor: wire up publish products action
a520b6b 
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@willopez
refactor: wireup make visible action
74ac86b 
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@willopez
refactor: wire up make hidden action in products view
d79b234 
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@willopez
refactor: wire up clone and archive bulk actions
0811991 
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@willopez willopez mentioned this pull request Jan 16, 2020
Merged
@willopez
refactor: some minor clean up
a0e85bf 
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@willopez
refactor: refresh table data after action is taken on products
9fc6f99 
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@willopez
refactor: add filters to orders tables
3224640 
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@willopez
chore: upgrade material ui lab package
da91fbe 
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@willopez
refactor: wire up orders date range filter
0ac8d47 
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@willopez
fix: lint errors
957865c 
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@willopez
refactor: add product thumbnail cell
fc8d66b 
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@willopez
refactor: add back link to order detail page
e898f50 
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@willopez
refactor: guard against undefined variables
b3c9d35 
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@willopez
refactor: add "Create product" button
3dbb8cb 
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@willopez
Merge branch 'trunk' into feature-use-new-data-table-in-products-view
5dcd693
@willopez
refactor: upgrade Catalyst and adapt products table to use latest
9ca73e3 
version of DataTable

Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@willopez
refator: use filtersByKey in orders table
0892991 
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@willopez
refactor: wire up filter by file
00a35c6 
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@willopez
refactor: correctly set product id column
a5c814b 
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@willopez
refactor: minor clean up
0d7cd47 
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@kieckhafer kieckhafer mentioned this pull request Jan 28, 2020
Merged
@willopez
refactor: wire up tag selector
83763cc 
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@willopez
refactor: remove unnecessary product UI and Meteor publications
bc34422 
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@willopez
refactor: revamp translations
65ad19d 
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@willopez willopez changed the title Feature: use new Catalyst data table in products view Feature: use new Catalyst data table in products view and update orders view Jan 28, 2020
@willopez
chore: upgrade Catalyst package
cdb1eab 
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@willopez
refactor: add filter by product ids manual filter
0e5acd4 
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@willopez
refactor: add missing translations to orders table
6863c42 
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@willopez willopez marked this pull request as ready for review January 29, 2020 22:22
@willopez
chore: remove unnecessary publication
d7219ed 
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@willopez
refactor: do not display the "create product" button when quickcard is
bbc4895 
open

Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@willopez
refactor: add header to created at column
b70036f 
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
mikemurray
mikemurray approved these changes Jan 29, 2020
View reviewed changes
Copy link
Member

@mikemurray mikemurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mikemurray mikemurray merged commit 691c51d into trunk Jan 29, 2020
@mikemurray mikemurray deleted the feature-use-new-data-table-in-products-view branch January 29, 2020 23:30
@kieckhafer kieckhafer mentioned this pull request Feb 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikemurray mikemurray mikemurray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use the new DataTable from the Reaction Catalyst system in the products view
2 participants
@willopez @mikemurray