refactor: remove alanning:roles and related user roles code #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
kieckhafer
changed the title
Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
…removeAlanningRoles # Conflicts: # .meteor/versions # imports/plugins/core/core/server/publications/collections/orders.js
kieckhafer
changed the title
Signed-off-by: Erik Kieckhafer <ek@ato.la>
aldeed
approved these changes
Feb 2, 2020
This was referenced Feb 3, 2020
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: minor
Type: feature|refactor
Issue
roles(now referred to as permissions where we can) used to be attached to users, andalanning:roleshelped manage keeping user roles in sync with group roles. We no longer use theuser.rolesobject, and instead strictly query groupspermissionsand see if a user is part of a group to see if they are allowed to make an action.Solution
Remove remaining code which references the
alanning:rolespackage, and update accordingly to get data from Groups.Breaking changes
Any custom code using
Roleswill need to be refactored.Testing
users.roleshas already occurred in other PRs, so just making sure you can still use admin as expected, without running into any permissions issues, should be sufficient.rolesrelated functionality is in theAccounts Groupspanel. See that you can rename groups as expected. The groups themselves, and the permissions inside the groups, need to be completely refactored to work with the new permissions (in another PR)