Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: permission issues in admin #198

Merged
merged 1 commit into from
Feb 4, 2020
Merged

fix: permission issues in admin #198

merged 1 commit into from
Feb 4, 2020

Conversation

kieckhafer
Copy link
Member

@kieckhafer kieckhafer commented Feb 3, 2020 •
edited
Loading

There were a few remaining issues after #193 was merged.

This PR fixes those issues.

Testing

  • See that you can edit a product

@kieckhafer
fix: permission issues in admin
58d7966 
Signed-off-by: Erik Kieckhafer <ek@ato.la>
willopez
willopez approved these changes Feb 3, 2020
View reviewed changes
Copy link
Member

@willopez willopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@willopez willopez merged commit 6846496 into trunk Feb 4, 2020
@willopez willopez deleted the fix-kieckhafer-permissionIssues branch February 4, 2020 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willopez willopez willopez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kieckhafer @willopez