Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PDP] Google+ message not carried over to G+ when sharing #2292

Closed
brent-hoover opened this issue May 17, 2017 · 4 comments · Fixed by #3645
Closed

[PDP] Google+ message not carried over to G+ when sharing #2292

brent-hoover opened this issue May 17, 2017 · 4 comments · Fixed by #3645
Assignees
Labels
bug For issues that describe a defect or regression in the released software

Comments

@brent-hoover
Copy link
Collaborator

Expected behavior

Message should be the default subject of the share

Actual Behavior

Message is not used

Steps to Reproduce the Behavior

  1. Configure G+ sharing in Dashboard
  2. Create a product
  3. Add a message to the G+ sharing
  4. Publish
  5. Click on G+ message
  6. Observe that this message is not used

Versions

Node: 7.10.0
NPM: 4.2.0
Meteor Node: 4.8.2
Meteor NPM: 4.5.0
Reaction CLI: 0.8.2
Reaction: 1.2.0
Reaction branch: release-1.2.0
Docker: 17.03.1-ce
@brent-hoover brent-hoover added the bug For issues that describe a defect or regression in the released software label May 19, 2017
@rnandhakumar1995
Copy link

update the "const url" in "get url" method, which is present in the file "imports/plugins/included/social/client/components/googleplus.js", with the following
const url = encodeURIComponent(preferredUrl+"&text="+this.props.description);

@brent-hoover
Copy link
Collaborator Author

Or maybe just remove Google+? Who uses Google+ in 2018?

@Akarshit
Copy link
Contributor

@zenweasel Should I remove G+?

@Akarshit Akarshit self-assigned this Feb 19, 2018
@brent-hoover
Copy link
Collaborator Author

That's a product question. Let's get it working if we can

aaronjudd pushed a commit that referenced this issue Feb 21, 2018
@spencern spencern mentioned this issue Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For issues that describe a defect or regression in the released software
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants