Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2292: Sending the text to G+ #3790

Merged
merged 1 commit into from
Feb 21, 2018
Merged

Fixes #2292: Sending the text to G+ #3790

merged 1 commit into from
Feb 21, 2018

Conversation

Akarshit
Copy link
Contributor

Resolves #2292
Impact: minor
Type: bugfix

Issue

The description was not being sent to the Google API.

Solution

Added text as URL parameter while calling Google API.

Testing

  1. Configure G+ sharing in Dashboard
  2. Create a product
  3. Add a message to the G+ sharing
  4. Publish
  5. Click on G+ message
  6. Observe that this message is used

@aaronjudd aaronjudd merged commit 1fb0435 into release-1.8.0 Feb 21, 2018
@aaronjudd aaronjudd deleted the fix-2292-akarshit-google-plus branch February 21, 2018 19:41
@spencern spencern mentioned this pull request Feb 22, 2018
Merged
@spencern spencern mentioned this pull request Mar 9, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jshimko jshimko jshimko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Akarshit @jshimko @aaronjudd