Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Marketplace] Permission list duplicated for marketplace shops #2728

Closed
mikemurray opened this issue Aug 23, 2017 · 3 comments
Closed

[Marketplace] Permission list duplicated for marketplace shops #2728

mikemurray opened this issue Aug 23, 2017 · 3 comments
Labels
bug For issues that describe a defect or regression in the released software

Comments

@mikemurray
Copy link
Member

mikemurray commented Aug 23, 2017 •
edited
Loading

Expected behavior

Should show only the permissions available for the current shop.

Actual Behavior

Shows primary shop permissions, followed by all marketplace shops.

Steps to Reproduce the Behavior

  1. Add one or more marketplace shops
  2. Switch to your new shop, and back to the primary shop in the shop switcher dropdown
  3. Open accounts and search the list and you'll see Account or Account View duplicated in the list for as many shops as you've added/switched to without refreshing the page.

permissions

EDIT Doesn't seem to happen by default, but when switching shop context in the dropdown. Maybe related to #2726

Versions

Node: 7.2.0
NPM: 5.3.0
Meteor Node: 4.8.4
Meteor NPM: 4.6.1
Reaction CLI: 0.11.0
Reaction: 1.5.0
Reaction branch: marketplace
Docker: 17.06.1-ce
@mikemurray mikemurray added the bug For issues that describe a defect or regression in the released software label Aug 23, 2017
@mikemurray
Copy link
Member Author

@impactmass can you verify this behavior.

@mikemurray mikemurray changed the title [Merkatplace] Permission list duplicated for marketplace shops [Marketplace] Permission list duplicated for marketplace shops Aug 23, 2017
@impactmass
Copy link
Contributor

impactmass commented Aug 24, 2017 •
edited
Loading

Verified. Working on it now.

It must have been a missing shopId in a Packages.find()

@impactmass impactmass mentioned this issue Aug 24, 2017
Merged
mikemurray pushed a commit that referenced this issue Aug 24, 2017
@impactmass @mikemurray
[Marketplace] Fix group error on Account Management Screen on Merchan…
8b67825 
…t shops #2726;#2728 (#2734)

* Move groups list check into parent component, freeing form component

* Add comment to func

* Add missing shopId to Packages.find

* Reduce text line length
@impactmass
Copy link
Contributor

Fixed by #2734

@spencern spencern mentioned this issue Oct 11, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug For issues that describe a defect or regression in the released software
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikemurray @impactmass