Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Marketplace] Fix group error on Account Management Screen on Merchant shops #2726;#2728 #2734

Merged
merged 5 commits into from
Aug 24, 2017

Conversation

impactmass
Copy link
Contributor

@impactmass impactmass commented Aug 24, 2017

Resolves #2726 and #2728

How To Test:

Code Changes Introduced:

  • The AdminInvite Form needs at least one "invitable" group to work properly. That was failing when the owner tried to see the merchant dashboard. I've moved that check into the parent component. So there is check that there's an "invitable"group before rendering the form.
  • I also added the missing shopId value to fix [Marketplace] Permission list duplicated for marketplace shops #2728

@impactmass impactmass changed the title [WIP] [Marketplace] Fix group error on Account Management Screen on Merchant shops #2726;#2728 [Marketplace] Fix group error on Account Management Screen on Merchant shops #2726;#2728 Aug 24, 2017
@impactmass
Copy link
Contributor Author

not sure what's happening to bitHound, but you can test this now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants