(refactor): Update circleci config to circleci workflowsv2 #3618
Conversation
|
|
||
| docker: | ||
| - image: node:8 | ||
| - image: circleci/node:8.9.3-browsers |
There was a problem hiding this comment.
Changing this per comment made here
| paths: | ||
| - ~/.meteor | ||
| # install OS dependencies | ||
| - run: sudo apt-get update |
There was a problem hiding this comment.
Added sudo here (and a couple other places) because the new node image throws permission denied errors on those commands. If there's a better way to this please point me to it...
| key: dev_bundle-{{ .Branch }} | ||
|
|
||
| # install Reaction CLI | ||
| - run: sudo npm install -g reaction-cli |
There was a problem hiding this comment.
This was done previously with yarn. I switched to npm here (for consistency), but I'll like to know if there's reason why yarn is preferred.
| working_directory: /home/reaction | ||
| # run automated tests | ||
| tests: | ||
| working_directory: ~/reaction |
There was a problem hiding this comment.
Changed from /home/reaction to ~/reaction. The 8.9.3-browsers image throws permission denied error on root folder. Any better way?
There was a problem hiding this comment.
Hi @impactmass. This is a minor suggestion because I'm sure that this will work as-is. ~ is expanded to home by the shell when it's not prefixed. But ~ is a typing convenience for the command line. In scripts it's generally preferred to use the $HOME var.
See:
- SO: Difference between home and tilde
- SO: Why use home over tilde in a shell script
- Bash Tilde Expansion Documentation.
That said, you did the right thing. The old path didn't work on that image because the user reaction doesn't exist in circleci/node:8.9.3-browsers and therefore the /home/reaction directory doesn't exist either.
There was a problem hiding this comment.
Thanks. I changed to $HOME. With that circleci fails on the checkout step.
Unable to create directory '$HOME/reaction. Not sure why yet.
Also, I did not get this part The old path didn't work on that image because the user reaction doesn't exist ... and therefore the /home/reaction. Were we creating a reaction user in the previous setup?
There was a problem hiding this comment.
There was never a reaction user. The previous container ran as root. That was just the directory I picked to checkout the code within the image. And ~/ definitely was a problem previously, so that's why I explicitly set it to /home/.
| - restore_cache: | ||
| name: Restoring Meteor cache | ||
| key: meteor | ||
| key: meteor-{{ .Branch }} |
There was a problem hiding this comment.
Added branch name to the keys for the cache primarily because the old cache that was generated on previous node:8 image is to be linked/restored to root locations on the new 8.9.3 (which also resulted in permission denied errors).
.circleci/config.yml
Outdated
|
|
||
| - save_cache: | ||
| paths: | ||
| - ~/node_modules |
There was a problem hiding this comment.
That's not where the app's node_modules are. It's ~/reaction/node_modules
…-circle-workflows
impactmass
changed the title
|
@impactmass Do you still need @jshimko to look at this or are you working with @ticean on it? |
impactmass
changed the title
impactmass
changed the title
|
closing this, will be opened as part of the linked issue above |
Refactor circleci config.
Part of #2858.
This PR updates:
-browsersimage that contains headless Chrome available for running client testsThis PR adds
test_publish_deployworkflow with three jobs (which we already had before):tests: which runs the app testspublish- builds docker image and publishdeployDocs- runs jsdoc and deploys to aws