(refactor): Update circleci config to circleci workflowsv2 #3618
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,12 @@ | ||
| version: 2 | ||
|
|
||
| jobs: | ||
| # run automated tests | ||
| tests: | ||
| working_directory: ~/reaction | ||
|
|
||
| docker: | ||
| - image: circleci/node:8.9.3-browsers | ||
|
There was a problem hiding this comment. Changing this per comment made here |
||
|
|
||
| environment: | ||
| - DOCKER_VERSION: 17.05.0-ce | ||
|
|
@@ -14,62 +15,137 @@ jobs: | |
| - TOOL_NODE_FLAGS: "--max-old-space-size=4096" | ||
|
|
||
| steps: | ||
| - checkout | ||
|
|
||
| - restore_cache: | ||
| name: Restoring Meteor cache | ||
| key: meteor-{{ .Branch }} | ||
|
There was a problem hiding this comment. Added branch name to the keys for the cache primarily because the old cache that was generated on previous node:8 image is to be linked/restored to root locations on the new 8.9.3 (which also resulted in permission denied errors). |
||
|
|
||
| # Install Meteor | ||
| - run: .circleci/install_meteor.sh | ||
|
|
||
| # install OS dependencies | ||
| - run: sudo apt-get update | ||
|
There was a problem hiding this comment. Added |
||
| - run: sudo apt-get install -y locales | ||
|
|
||
| # fix Meteor/Mongo locale issue on Debian | ||
| # https://github.com/meteor/meteor/issues/4019 | ||
| - run: sudo locale-gen en_US.UTF-8 | ||
| - run: sudo localedef -i en_GB -f UTF-8 en_US.UTF-8 | ||
|
|
||
| # Download and cache dependencies | ||
| - restore_cache: | ||
| keys: | ||
| - v1-dependencies-{{ checksum "package.json" }}-{{ .Branch }} | ||
| # fallback to using the latest cache if no exact match is found | ||
| - v1-dependencies-{{ .Branch }} | ||
|
|
||
| # Install dependencies | ||
| - run: meteor npm install | ||
|
|
||
| - restore_cache: | ||
| name: Restoring Meteor dev_bundle cache | ||
| key: dev_bundle-{{ .Branch }} | ||
|
|
||
| # install Reaction CLI | ||
| - run: sudo npm install -g reaction-cli | ||
|
There was a problem hiding this comment. This was done previously with |
||
|
|
||
| # run reaction tests | ||
| - run: .circleci/tests.sh | ||
|
|
||
| - save_cache: | ||
| name: Saving Meteor dev_bundle to cache | ||
| key: dev_bundle-{{ .Branch }} | ||
| paths: | ||
| - ~/reaction/.meteor/local | ||
|
|
||
| - save_cache: | ||
| paths: | ||
| - ~/reaction/node_modules | ||
| key: v1-dependencies-{{ checksum "package.json" }} | ||
|
|
||
| - save_cache: | ||
| name: Saving Meteor to cache | ||
| key: meteor-{{ .Branch }} | ||
| paths: | ||
| - ~/.meteor | ||
|
|
||
|
|
||
| # build a Reaction image and publish to DockerHub | ||
| publish: | ||
| working_directory: ~/reaction | ||
|
|
||
| docker: | ||
| - image: node:8.9.3 | ||
|
|
||
| environment: | ||
| - DOCKER_VERSION: 17.05.0-ce | ||
| - DOCKER_COMPOSE_VERSION: 1.15.0 | ||
| - METEOR_ALLOW_SUPERUSER: true | ||
| - TOOL_NODE_FLAGS: "--max-old-space-size=4096" | ||
|
|
||
| steps: | ||
| - setup_remote_docker | ||
| - checkout | ||
|
|
||
| # Install Docker client & compose | ||
| - run: .circleci/install.sh | ||
|
|
||
| - run: | ||
| command: .circleci/build.sh | ||
| no_output_timeout: 30m | ||
|
|
||
| - run: .circleci/deploy.sh | ||
|
|
||
|
|
||
| # deploy reaction docs | ||
| deployDocs: | ||
| working_directory: ~/reaction | ||
|
|
||
| docker: | ||
| - image: node:8.9.3 | ||
|
|
||
| environment: | ||
| - DOCKER_VERSION: 17.05.0-ce | ||
| - DOCKER_COMPOSE_VERSION: 1.15.0 | ||
| - METEOR_ALLOW_SUPERUSER: true | ||
| - TOOL_NODE_FLAGS: "--max-old-space-size=4096" | ||
|
|
||
| steps: | ||
| - checkout | ||
|
|
||
| # install OS dependencies | ||
| - run: apt-get update | ||
| - run: apt-get install -y locales | ||
| - run: | ||
| command: .reaction/jsdoc/build.sh | ||
| no_output_timeout: 2m | ||
|
|
||
| # deploy the docs if on master branch (based on workflow filter) | ||
| - run: | ||
| command: | | ||
| if [[ "${API_DOC_BUCKET}" && "${API_DOC_BUCKET_REGION}" ]]; then | ||
| aws s3 sync /tmp/reaction-docs ${API_DOC_BUCKET} --delete --region ${API_DOC_BUCKET_REGION} | ||
| else | ||
| echo "S3 bucket configuration not found for jsdocs" | ||
| echo "Set API_DOC_BUCKET and API_DOC_BUCKET_REGION to build and deploy jsdocs to S3" | ||
| fi | ||
|
|
||
| workflows: | ||
| version: 2 | ||
|
|
||
| test_publish_deploy: | ||
| jobs: | ||
| - tests | ||
|
|
||
| - publish: | ||
| requires: | ||
| - tests | ||
|
|
||
| - deployDocs: | ||
| requires: | ||
| - tests | ||
| filters: | ||
| branches: | ||
| only: | ||
| - master | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| #!/bin/bash | ||
|
|
||
| set -x | ||
|
|
||
| # install Meteor if it's not already | ||
| if [[ -f ~/.meteor/meteor ]]; then | ||
| printf "\nMeteor already installed. Creating symlink.\n" | ||
| sudo ln -s ~/.meteor/meteor /usr/local/bin/meteor; | ||
| else | ||
| printf "\Installing Meteor\n" | ||
| curl https://install.meteor.com | /bin/sh | ||
| fi |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed from
/home/reactionto~/reaction. The8.9.3-browsersimage throws permission denied error on root folder. Any better way?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @impactmass. This is a minor suggestion because I'm sure that this will work as-is.
~is expanded to home by the shell when it's not prefixed. But~is a typing convenience for the command line. In scripts it's generally preferred to use the$HOMEvar.See:
That said, you did the right thing. The old path didn't work on that image because the user
reactiondoesn't exist incircleci/node:8.9.3-browsersand therefore the/home/reactiondirectory doesn't exist either.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I changed to $HOME. With that circleci fails on the checkout step.
Unable to create directory '$HOME/reaction. Not sure why yet.Also, I did not get this part
The old path didn't work on that image because the userreactiondoesn't exist ... and therefore the /home/reaction. Were we creating areactionuser in the previous setup?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was never a
reactionuser. The previous container ran as root. That was just the directory I picked to checkout the code within the image. And~/definitely was a problem previously, so that's why I explicitly set it to/home/.