Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emitting afterAddTagsToProducts, afterTagDelete, afterRemoveTagsFromProducts #6541

Conversation

vishalmalu
Copy link
Contributor

Impact: minor
Type: feature

Issue
This PR emits following additional events when respective mutations have been executed.

  • afterAddTagsToProducts
  • afterRemoveTagsFromProducts
  • afterTagDelete

…sFromProducts events

Signed-off-by: vishalmalu <vishal.malu@gmail.com>
@changeset-bot
Copy link

changeset-bot bot commented Oct 3, 2022

🦋 Changeset detected

Latest commit: fa4763e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@reactioncommerce/api-plugin-products Minor
@reactioncommerce/api-plugin-tags Minor
@reactioncommerce/api-plugin-carts Major
@reactioncommerce/api-plugin-payments-stripe-sca Patch
@reactioncommerce/reaction-api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Signed-off-by: vishalmalu <vishal.malu@gmail.com>
Signed-off-by: vishalmalu <vishal.malu@gmail.com>
Signed-off-by: vishalmalu <vishal.malu@gmail.com>
@tedraykov tedraykov self-requested a review October 3, 2022 16:59
Copy link
Collaborator

@tedraykov tedraykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run changeset on npx changeset to generate the changelog files. This is required to bump the plugin versions.
Apart from that the PR is good to go.

Signed-off-by: vishalmalu <vishal.malu@gmail.com>
@vishalmalu
Copy link
Contributor Author

@tedraykov I've added changeset.

Signed-off-by: vishalmalu <vishal.malu@gmail.com>
Signed-off-by: vishalmalu <vishal.malu@gmail.com>
@brent-hoover brent-hoover self-requested a review October 7, 2022 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants