Fix crashes related to loading React 16.4.1 #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If React fails to load from a user-provided bundle, the script load exception would be hidden from the user, because the exception is stored to a field and then rethrown later. EnsureReactLoaded was getting called before the real exception was thrown, which threw a new (unhelpful) exception.
In some cases, React (or other libraries) will assume that setTimeout and clearTimeout are defined on the global scope, without invoking it. We should still throw an error in case a consumer expects this to just work on the server (it won't), but we can avoid a crash by defining the function on the global scope. For context: reactjs#555
dustinsoftware
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #555