Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crashes related to loading React 16.4.1 #558

Merged
merged 2 commits into from
Jun 30, 2018
Merged

Fix crashes related to loading React 16.4.1 #558

merged 2 commits into from
Jun 30, 2018

Commits on Jun 29, 2018

  1. Fix unhelpful error message if React can't be loaded 

    If React fails to load from a user-provided bundle, the script load
exception would be hidden from the user, because the exception is stored
to a field and then rethrown later. EnsureReactLoaded was
getting called before the real exception was thrown, which threw a new
(unhelpful) exception.
    @dustinsoftware
    dustinsoftware committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    8fdb2c0 View commit details
    Browse the repository at this point in the history

  2. Avoid crash if setTimeout/clearTimeout is referenced 

    In some cases, React (or other libraries) will assume that setTimeout
and clearTimeout are defined on the global scope, without invoking it.

We should still throw an error in case a consumer expects this to just
work on the server (it won't), but we can avoid a crash by defining the
function on the global scope.

For context: reactjs#555
    @dustinsoftware
    dustinsoftware committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    18d608d View commit details
    Browse the repository at this point in the history