-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fixed] Clear the delayed close timer when modal opens again #134
Conversation
@CompuIves Any chance you'd be willing to put a spec in place with this? It looks like a pretty good change, but I'd prefer that changes have associated specs with them. |
Pinging @CompuIves. This seems right. Can you fix the conflict and add a spec for this? |
Ah, I completely missed the first reply, sorry! I'm currently travelling in SE-Asia without any access to my macbook. I can create a spec when I come back (May 26th) but I'm not sure if you would like to wait so long. |
@CompuIves nice. Do you mind if I jump in this fix? |
@diasbruno Sure, no problem! |
@CompuIves thanks. I'll keep a reference to your work on it. |
yep, almost forgot...i'll finish this today! |
Hi! What's the progress of this fix? |
@CompuIves I've rebased the branch and added the test to it. I didn't had time to work on this, but I believe it's finished (almost). You can check it here... |
continuation of the PR reactjs#134. thanks, @CompuIves.
continuation of the PR reactjs#134. thanks, @CompuIves.
@claydiffrient this PR can be closed in favor of #189. |
This PR can be closed in favor of #189. |
* [fixed] Clear the delayed close timer when modal opens again * [fixed] added test for the timeout case. continuation of the PR #134. thanks, @CompuIves.
Currently there is an inconsistency when there is a delayed close and right after the start of this close the modal opens again.
Graphic:
Now we have this state:
Which gives an invisible modal.
This PR should fix it by just skipping the open logic (since the modal is already open) and clearing the timeout and returning beforeClose to false.