Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fixed] clear the delayed close timer when modal opens again. #189

Merged
merged 2 commits into from
Jun 30, 2016
Merged

[fixed] clear the delayed close timer when modal opens again. #189

merged 2 commits into from
Jun 30, 2016

Conversation

diasbruno
Copy link
Collaborator

Continuation of the fix #134. Look at this PR (#134) for more information.

  • added spec to validate the fix.
  • commits were not squashed to preserve the commit made by @CompuIves.

Thanks, @CompuIves.

@CompuIves
Copy link
Contributor

Thanks a lot for writing a test for it! Hopefully we can merge this soon :shipit:.

@diasbruno diasbruno mentioned this pull request Jun 24, 2016
Closed
@diasbruno
Copy link
Collaborator Author

@claydiffrient can you have a look in this PR?

@claydiffrient
Copy link
Contributor

Looks good merging now

@claydiffrient claydiffrient merged commit 13bd46e into reactjs:master Jun 30, 2016
@claydiffrient
Copy link
Contributor

Released in v1.4.0

@diasbruno diasbruno deleted the fix/clearTimeout branch June 14, 2017 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@diasbruno @CompuIves @claydiffrient