Added phpunit to the dev requirements. Fixed test cases to no longer … #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…use deprecated `getMock` function.
|
Have changed / partially reverted this to instead require PHPUnit 4.8 |
|
Personally, I'm undecided on this, but I know similar patches have been rejected in the past. I guess this worth discussing in the meta repo? |
|
@clue What do you mean, you don't think we should use I tried to run tests having installed phpunit 5 locally and they failed; how would I find out what version of PHPUnit I should use if it's not in require-dev? |
|
I think there are valid reasons both pro and contra adding |
|
Closed via #57 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…use deprecated
getMockfunction.