Add PHPUnit 4.8 to require-dev #57
Conversation
| install: | ||
| - composer install --prefer-source --no-interaction | ||
|
|
||
| script: | ||
| - phpunit --coverage-text | ||
| - ./vendor/binphpunit -v --coverage-text |
There was a problem hiding this comment.
Missing slash, should be ./vendor/bin/phpunit
| @@ -10,8 +10,11 @@ php: | |||
|
|
|||
| sudo: false | |||
|
|
|||
| before_install: | |||
| - composer self-update | |||
There was a problem hiding this comment.
There is no need for this anymore as travis already do it here while your update call runs here.
|
pushed changes as requested. |
| @@ -14,4 +14,4 @@ install: | |||
| - composer install --prefer-source --no-interaction | |||
|
|
|||
| script: | |||
| - phpunit --coverage-text | |||
| - ./vendor/bin/phpunit -v --coverage-text | |||
There was a problem hiding this comment.
What's the motivation for adding the verbose flag?
|
To be quite honest. I saw it in a couple of the other repos. I've seen variety of differences in how each Travis.yml file is setup. I've been contemplating posting a "bug report" on the meta repo to begin a discussion about a standardized (where possible) configuration.
For example:
- store phpunit analysis in clover.xml format for post analysis?
- test against lowest deps ?
- test against highest deps?
- test against PHP 7.1?
Cheers,
Shaun
…Sent from my iPhone
On Jan 11, 2017, at 6:33 PM, Christian Lück ***@***.***> wrote:
@clue commented on this pull request.
In .travis.yml:
> @@ -14,4 +14,4 @@ install:
- composer install --prefer-source --no-interaction
script:
- - phpunit --coverage-text
+ - ./vendor/bin/phpunit -v --coverage-text
What's the motivation for adding the verbose flag?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
I think this makes perfect sense 👍 In the meantime, I would suggest reverting this (unrelated and undocumented) change so we can get this in quicker 👍 Also, may I ask you to sqash/force-push your changes so this is a single commit only? Thanks! |
|
@clue reverted / squashed / force-pushed as requested. |
|
Thanks! The build currently fails because this is based on on older version of the master branch. A rebase should help 👍 |
|
@clue rebased off of upstream master as requested |
As mentioned in reactphp/reactphp#354
Added phpunit 4.8 to require-dev section of composer.json
Modified travisci config to perform a composer selfupdate and to use local phpunit.