Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude migrations, vendor, .min.js, .svg, and static/*.js from pre-commit #211

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

yarikoptic
Copy link
Contributor

Those files are copied from other sources or edited by other tools
and IMHO not subject for pre-commit handling.

Refs:
- readthedocs/readthedocs.org#11200
- readthedocs/readthedocs.org#11199
yarikoptic added a commit to yarikoptic/readthedocs.org that referenced this pull request Mar 8, 2024
@yarikoptic yarikoptic changed the title Exclude vendor, .min.js, .svg, and static/*.js from pre-commit Exclude migrations, vendor, .min.js, .svg, and static/*.js from pre-commit Mar 8, 2024
yarikoptic added a commit to yarikoptic/readthedocs.org that referenced this pull request Mar 8, 2024
@yarikoptic
Copy link
Contributor Author

per comment elsewhere, I have now changed to exclude migrations only from black, isort and the "pre-commit-hooks" tune ups

Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me 👍

@ericholscher ericholscher merged commit 24ecab8 into readthedocs:main Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants