Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Results of two runs of pre-commit run --all -- still fails due to "prospector" #11199

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yarikoptic
Copy link
Contributor

@yarikoptic yarikoptic commented Mar 8, 2024

Apparently either pre-commit was not "applied" throughout the codebase or may be versions of the tools are insufficiently pin'ed down -- that results in pre-commit introducing changes to the files if ran through the entire clean codebase. IMHO it is very undesired since could interfere with actual changes, making PRs harder to review etc.

note that it even applies to vendor/ folder.

This PR is more of a demonstration of a problem than something to be merged, thus - making it draft.


📚 Documentation previews 📚

yarikoptic added a commit to yarikoptic/common that referenced this pull request Mar 8, 2024
Those files are copied from other sources or edited by other tools
and IMHO not subject for pre-commit handling.

Refs:
- readthedocs/readthedocs.org#11200
- readthedocs/readthedocs.org#11199
ericholscher pushed a commit to readthedocs/common that referenced this pull request Oct 14, 2024
…ommit (#211)

* Exclude vendor, .min.js, .svg, and static/*.js from pre-commit

Those files are copied from other sources or edited by other tools
and IMHO not subject for pre-commit handling.

Refs:
- readthedocs/readthedocs.org#11200
- readthedocs/readthedocs.org#11199

* Exclude migrations from isort, black, and pre-commit-hooks tuneups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant