Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error pages use inline JS #411

Closed
stsewd opened this issue Jul 3, 2024 · 0 comments · Fixed by #442
Closed

Error pages use inline JS #411

stsewd opened this issue Jul 3, 2024 · 0 comments · Fixed by #442
Assignees
@agjohnson
Labels
Accepted Accepted issue on our roadmap Bug A bug
Milestone
Template public b...

Comments

@stsewd
Copy link
Member

stsewd commented Jul 3, 2024

ext-theme/readthedocsext/theme/templates/errors/dashboard/base.html

Lines 44 to 46 in 846d194

<p>
<a class="ui button" href="javascript:history.back();">{% trans "Go back" %}</a>
</p>

ext-theme/readthedocsext/theme/templates/support/error.html

Lines 22 to 26 in 846d194

<a href="javascript:history.back()"
class="ui primary button">
<i class="fad fa-chevron-left icon"></i>
{% trans "Go back" %}
</a>

@stsewd stsewd changed the title Error pages uses inline JS Error pages use inline JS Jul 3, 2024
@agjohnson agjohnson added Bug A bug Accepted Accepted issue on our roadmap labels Jul 8, 2024
@agjohnson agjohnson self-assigned this Aug 6, 2024
agjohnson added a commit that referenced this issue Aug 8, 2024
@agjohnson
First pass updating dashboard error pages
67a3c1e 
- Refs #411
@agjohnson agjohnson mentioned this issue Aug 8, 2024
Merged
agjohnson added a commit that referenced this issue Aug 23, 2024
@agjohnson
First pass updating dashboard error pages
ca4ea22 
- Refs #411
agjohnson added a commit that referenced this issue Sep 6, 2024
@agjohnson
First pass updating dashboard error pages
d00fd3a 
- Refs #411
agjohnson added a commit that referenced this issue Sep 6, 2024
@agjohnson
Add support for proxito error pages (#442)
c6c883c 
* Add more extension points on base template for overriding in proxito

* Proxito base template for overriding base template blocks

* Fix import on base template

* First pass updating dashboard error pages

- Refs #411

* Copy dashboard error pages and lightly adapt for proxito

* Tune error page copy for documentation sites

* Only use a home link on pages where it makes sense

Don't put a home link on "project not found" error page, for example.

* Update styles on proxito error pages

This centers the error block and uses more standard styles from cards to
for the content -- namely the header and meta blocks.

* Error status code correction on 4xx/5xx pages

* Add missing 500 template

The base template was showing through.

* Add proxy templates for spam.html

This just uses 410.html, but the views still reference the named
`spam.html` template.

* Add comment on proxito base template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agjohnson agjohnson

Labels
Accepted Accepted issue on our roadmap Bug A bug
Projects
📍Roadmap
Archived in project
Milestone
Template public beta - community
Development

Successfully merging a pull request may close this issue.

Add support for proxito error pages readthedocs/ext-theme
2 participants
@agjohnson @stsewd