-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for proxito error pages #442
Conversation
966cb25
to
38b3f59
Compare
Don't put a home link on "project not found" error page, for example.
This centers the error block and uses more standard styles from cards to for the content -- namely the header and meta blocks.
The base template was showing through.
1724897
to
cfaf1d0
Compare
I finally had a chance today to get back to this work and wrap it up. I have tested this a good amount, including the underlying, required PRs. Here is where this all is right now. The errors are centered in the window and are pretty minimal in comparison to what the error pages are now. The lack of major branding, header, and footer are all intentional. The global search input was dropped for now too, as was most of the content from the contextualized 404 pages that seemed to target maintainers instead of project readers. The DNS 404 error still targets project maintainers however. On desktop: On mobile: Errors400401403404 (unrecognized custom domain)404 (page not found)404 (translation not found)404 (version not found)404 (project not found)410418429500504 |
This just uses 410.html, but the views still reference the named `spam.html` template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 💯
These pages are minimal error pages compared to the dashboard pages, and don't
have a header, footer, our JS, or our icons.
Also tunes up dashboard error pages to match, right before the pages were
copied.