Add support for proxito error pages #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agjohnson
force-pushed
the
agj/proxito-errors
branch
from
966cb25
to
38b3f59
Compare
Don't put a home link on "project not found" error page, for example.
This centers the error block and uses more standard styles from cards to for the content -- namely the header and meta blocks.
The base template was showing through.
agjohnson
force-pushed
the
agj/proxito-errors
branch
from
1724897
to
cfaf1d0
Compare
|
I finally had a chance today to get back to this work and wrap it up. I have tested this a good amount, including the underlying, required PRs. Here is where this all is right now. The errors are centered in the window and are pretty minimal in comparison to what the error pages are now. The lack of major branding, header, and footer are all intentional. The global search input was dropped for now too, as was most of the content from the contextualized 404 pages that seemed to target maintainers instead of project readers. The DNS 404 error still targets project maintainers however. On desktop:
On mobile:
Errors400
401
403
404 (unrecognized custom domain)
404 (page not found)
404 (translation not found)
404 (version not found)
404 (project not found)
410
418
429
500
504
|
This just uses 410.html, but the views still reference the named `spam.html` template.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These pages are minimal error pages compared to the dashboard pages, and don't
have a header, footer, our JS, or our icons.
Also tunes up dashboard error pages to match, right before the pages were
copied.