Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface "abandoned" state on projects in UI #4995

Closed
wants to merge 30 commits into from
Closed

Surface "abandoned" state on projects in UI #4995

wants to merge 30 commits into from

Conversation

dojutsu-user
Copy link
Member

@dojutsu-user dojutsu-user commented Dec 13, 2018

Issue #3382

  • Djano site admin functions for sending an email to project owners that their namespace has been requested
  • Djano site admin function for marking a project as abandoned
    • Adds -abandoned to slug
    • Marks Project.is_abandoned
    • Sends an email notifying the user of the change and a link to the new project/doc pages
  • Project detail sidebar piece that states project is abandoned
  • Tests

@dojutsu-user dojutsu-user changed the title admin func for to update the abandoned project's slug Surface "abandoned" state on projects in UI Dec 13, 2018
@codecov
Copy link

codecov bot commented Dec 13, 2018

Codecov Report

Merging #4995 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4995      +/-   ##
==========================================
+ Coverage   76.94%   76.96%   +0.01%     
==========================================
  Files         158      158              
  Lines       10020    10035      +15     
  Branches     1258     1258              
==========================================
+ Hits         7710     7723      +13     
+ Misses       1981     1978       -3     
- Partials      329      334       +5
Impacted Files Coverage Δ
readthedocs/projects/models.py 85.62% <100%> (-0.35%) ⬇️
readthedocs/projects/admin.py 93.23% <100%> (+1.72%) ⬆️
readthedocs/projects/notifications.py 100% <100%> (ø) ⬆️
readthedocs/projects/tasks.py 70.65% <100%> (-0.43%) ⬇️
readthedocs/vcs_support/backends/hg.py 64.51% <0%> (-3.18%) ⬇️
readthedocs/notifications/storages.py 82.53% <0%> (-3.18%) ⬇️
readthedocs/doc_builder/environments.py 86.24% <0%> (-0.8%) ⬇️
readthedocs/projects/exceptions.py 84.21% <0%> (-0.79%) ⬇️
... and 11 more

@dojutsu-user dojutsu-user changed the title Surface "abandoned" state on projects in UI [WIP] Surface "abandoned" state on projects in UI Dec 13, 2018
@dojutsu-user
Copy link
Member Author

@agjohnson
Need your advice here.
Also, I think we should store the date on which the user is notified for requesting a namespace to track the 6 week period.
And I think the code in this PR is little in-efficient in terms of speed and memory. Can there be any improvements?

@dojutsu-user dojutsu-user changed the title [WIP] Surface "abandoned" state on projects in UI Surface "abandoned" state on projects in UI Dec 18, 2018
@agjohnson
Copy link
Contributor

Great, this is looking good so far! I didn't do a full review, we'll hopefully get to full review of this shortly, but there might be a delay in review here as this is off our roadmap.

I gave a really quick glance and this seems to be replicating our notification system. You should move the email/on site notifications to use this system instead of using django pieces directly.

@agjohnson agjohnson added the PR: work in progress Pull request is not ready for full review label Dec 19, 2018
@dojutsu-user
Copy link
Member Author

dojutsu-user commented Dec 19, 2018

@agjohnson
Thanks.
Also, I have a little confusion, I think the notification system built is for the users who are logged in.
But the message This project is abandoned is to be shown to everyone on the project page (readthedocs.org/projects/project-slug/). So, I don't think that we can use that here.

Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't do a full review of this, but tried to give some feedback regarding the notification system and an issue about changing the slug directly.

readthedocs/projects/admin.py Outdated Show resolved Hide resolved
readthedocs/projects/admin.py Outdated Show resolved Hide resolved
readthedocs/projects/admin.py Show resolved Hide resolved
@dojutsu-user
Copy link
Member Author

I closed and reopend the PR for the travis to restart.

@humitos humitos removed the PR: work in progress Pull request is not ready for full review label Jan 28, 2019
@humitos humitos requested a review from a team January 28, 2019 20:03
@stale
Copy link

stale bot commented May 3, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label May 3, 2019
@dojutsu-user
Copy link
Member Author

Still valid bot.

@stale stale bot removed the Status: stale Issue will be considered inactive soon label May 3, 2019
@humitos
Copy link
Member

humitos commented May 20, 2019

It seems that this PR is getting stale over and over again because we haven't had the time to review it. @rtfd/core we should try to take it a look or close it for now if we feel that it's too much outside of our roadmap at this point.

@stale
Copy link

stale bot commented Jul 4, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label Jul 4, 2019
@dojutsu-user dojutsu-user removed the Status: stale Issue will be considered inactive soon label Jul 4, 2019
@stale
Copy link

stale bot commented Aug 18, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label Aug 18, 2019
@stale stale bot closed this Aug 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: stale Issue will be considered inactive soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants