Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow changing of slug #5154

Closed
wants to merge 2 commits into from
Closed

Allow changing of slug #5154

wants to merge 2 commits into from

Conversation

dojutsu-user
Copy link
Member

Closes #1440

dojutsu-user
dojutsu-user commented Jan 22, 2019
View reviewed changes
readthedocs/rtd_tests/tests/test_project_forms.py
@@ -29,6 +30,7 @@
EmailHookForm
)
from readthedocs.projects.models import EnvironmentVariable, Project
from readthedocs.projects.tasks import rename_project_dir
Copy link
Member Author

@dojutsu-user dojutsu-user Jan 22, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have implemented this task in PR #4995 (code) which is yet to be merged. It is better to merge this PR after #4995 for the reusability of the function.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, Travis will fail for now.

@humitos
Copy link
Member

humitos commented Mar 18, 2019

Thanks @dojutsu-user! We decided that we are not going to allow changing the slug by the user for now. I added a note in our docs at #5403.

I'm closing this PR here. We can revisit it later if we change our mind.

@humitos humitos closed this Mar 18, 2019
@dojutsu-user dojutsu-user deleted the allow-changing-slug branch March 18, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dojutsu-user @humitos