[C#] Make DirectBuffer.CheckLimit inlinable #840
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DirectBuffer.CheckLimit(int limit) is called in a lot of places during encoding and decoding and would profit from being inlined by the JIT Compiler. Currently it can't because of the throw statements and it's size. This change extracts the cold path where the check fails into a separate method, making CheckLimit itself eligible for inlining and resulting in a measureable performance improvement.
Running the existing benchmark project:
Before:
After:
I also tried a BenchmarkDotNet benchmark based on the car example (https://gist.github.com/szehetner/5ed4f7acceedfb8bce092b10f829ba92)
before:
after:
Btw, I would suggest to convert the existing benchmark project to BenchmarkDotNet, as this is the de-facto standard for .NET benchmarks. I could create another PR for this if desired.