Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C#] Convert benchmarks to BenchmarkDotNet #841

Merged
merged 4 commits into from
Apr 2, 2021

Conversation

szehetner
Copy link
Contributor

As mentioned in #840, this converts the C# benchmark project to use BenchmarkDotNet instead of the handcrafted benchmark logic.

Notable changes:

  • The target framework (for the benchmark project only) was changed from .NET Framework 4.5 to 4.6.1 as this is the minimum required by BenchmarkDotNet (needs to be netstandard 2.0 compatible).
  • The output assembly was renamed to sbe-benchmarks (BenchmarkDotNet requires the assembly to have the same name as the .csproj file)

Benchmarks:

  • MarketDataBenchmark is basically the same as the existing one, only the BenchmarkState class was merged into it.
  • CarBenchmark is based on the car example, covering more features.

@mjpt777 mjpt777 merged commit 13a2000 into real-logic:master Apr 2, 2021
@mjpt777
Copy link
Contributor

mjpt777 commented Apr 2, 2021

Note there are a lot of warnings after merging this PR in the benchmarks. The assigned values probably need to be consume to make the benchmark valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants