Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PrivateActionRule in Swift 5.2 #3092

Merged
merged 1 commit into from
Feb 10, 2020
Merged

Conversation

marcelofabri
Copy link
Collaborator

No description provided.

@SwiftLintBot
Copy link

1 Warning
⚠️ Please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.
12 Messages
📖 Linting Aerial with this PR took 0.49s vs 0.49s on master (0% slower)
📖 Linting Alamofire with this PR took 0.79s vs 0.79s on master (0% slower)
📖 Linting Firefox with this PR took 3.49s vs 3.44s on master (1% slower)
📖 Linting Kickstarter with this PR took 5.64s vs 5.55s on master (1% slower)
📖 Linting Moya with this PR took 0.45s vs 0.45s on master (0% slower)
📖 Linting Nimble with this PR took 0.55s vs 0.55s on master (0% slower)
📖 Linting Quick with this PR took 0.3s vs 0.3s on master (0% slower)
📖 Linting Realm with this PR took 0.93s vs 1.03s on master (9% faster)
📖 Linting SourceKitten with this PR took 0.47s vs 0.46s on master (2% slower)
📖 Linting Sourcery with this PR took 2.42s vs 2.37s on master (2% slower)
📖 Linting Swift with this PR took 7.63s vs 7.6s on master (0% slower)
📖 Linting WordPress with this PR took 6.0s vs 5.91s on master (1% slower)

Here's an example of your CHANGELOG entry:

* Fix PrivateActionRule in Swift 5.2.  
  [marcelofabri](https://github.com/marcelofabri)
  [#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by 🚫 Danger

@marcelofabri marcelofabri merged commit c5e7bb3 into master Feb 10, 2020
@marcelofabri marcelofabri deleted the mf-private-action-swift-5.2 branch February 10, 2020 06:16
optionalendeavors added a commit to optionalendeavors/SwiftLint that referenced this pull request Jul 12, 2020
* master: (101 commits)
  JUnit reporter for GitLab artifact:report:junit (realm#3177)
  Add empty changelog section
  release 0.39.2
  Update CI to run jobs with Xcode 11.0 to 11.4 (realm#3168)
  Fix false positives in valid_ibinspectable rule when using Swift 5.2 (realm#3155)
  Fix attributes rule false positive with Swift 5.2 (realm#3154)
  Fix CHANGELOG link
  Fix false positives in redundant_objc_attribute with Swift 5.2 (realm#3152)
  Fix false positives on implicit_getter with Swift 5.2+ (realm#3151)
  Simplify regex (realm#3145)
  fix links about configuration rules (realm#3142)
  Add unused_import config options to require imports for each module used (realm#3123)
  Add empty changelog section
  release 0.39.1
  Temporarily remove all SwiftSyntax rules and support (realm#3107)
  Fix unused_import rule reported locations and corrections (realm#3106)
  release 0.39.0
  Fix false positive in `empty_string` rule with multiline literals (realm#3101)
  Fix PrivateActionRule in Swift 5.2 (realm#3092)
  Fix false positive in implicit_getter with Swift 5.2 (realm#3099)
  ...

# Conflicts:
#	Source/SwiftLintFramework/Extensions/SwiftLintFile+Regex.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants