Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positives in redundant_objc_attribute with Swift 5.2 #3152

Merged
merged 1 commit into from
Mar 27, 2020

Conversation

marcelofabri
Copy link
Collaborator

No description provided.

@SwiftLintBot
Copy link

12 Messages
📖 Linting Aerial with this PR took 1.34s vs 1.31s on master (2% slower)
📖 Linting Alamofire with this PR took 2.2s vs 2.18s on master (0% slower)
📖 Linting Firefox with this PR took 9.07s vs 8.95s on master (1% slower)
📖 Linting Kickstarter with this PR took 14.16s vs 14.0s on master (1% slower)
📖 Linting Moya with this PR took 1.3s vs 1.3s on master (0% slower)
📖 Linting Nimble with this PR took 1.34s vs 1.36s on master (1% faster)
📖 Linting Quick with this PR took 0.53s vs 0.53s on master (0% slower)
📖 Linting Realm with this PR took 2.35s vs 2.31s on master (1% slower)
📖 Linting SourceKitten with this PR took 1.0s vs 0.99s on master (1% slower)
📖 Linting Sourcery with this PR took 6.75s vs 6.68s on master (1% slower)
📖 Linting Swift with this PR took 12.56s vs 12.51s on master (0% slower)
📖 Linting WordPress with this PR took 15.17s vs 15.23s on master (0% faster)

Generated by 🚫 Danger

@marcelofabri marcelofabri merged commit 0bbbcb0 into master Mar 27, 2020
@marcelofabri marcelofabri deleted the marcelo/fix-tests branch March 27, 2020 02:23
pull bot pushed a commit to scope-demo/SwiftLint that referenced this pull request Mar 27, 2020
optionalendeavors added a commit to optionalendeavors/SwiftLint that referenced this pull request Jul 12, 2020
* master: (101 commits)
  JUnit reporter for GitLab artifact:report:junit (realm#3177)
  Add empty changelog section
  release 0.39.2
  Update CI to run jobs with Xcode 11.0 to 11.4 (realm#3168)
  Fix false positives in valid_ibinspectable rule when using Swift 5.2 (realm#3155)
  Fix attributes rule false positive with Swift 5.2 (realm#3154)
  Fix CHANGELOG link
  Fix false positives in redundant_objc_attribute with Swift 5.2 (realm#3152)
  Fix false positives on implicit_getter with Swift 5.2+ (realm#3151)
  Simplify regex (realm#3145)
  fix links about configuration rules (realm#3142)
  Add unused_import config options to require imports for each module used (realm#3123)
  Add empty changelog section
  release 0.39.1
  Temporarily remove all SwiftSyntax rules and support (realm#3107)
  Fix unused_import rule reported locations and corrections (realm#3106)
  release 0.39.0
  Fix false positive in `empty_string` rule with multiline literals (realm#3101)
  Fix PrivateActionRule in Swift 5.2 (realm#3092)
  Fix false positive in implicit_getter with Swift 5.2 (realm#3099)
  ...

# Conflicts:
#	Source/SwiftLintFramework/Extensions/SwiftLintFile+Regex.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants