Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CloudFront Origin Access Control (#1019) #1021

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Add CloudFront Origin Access Control (#1019) #1021

merged 2 commits into from
Jun 28, 2023

Conversation

npellegrin
Copy link
Contributor

@npellegrin npellegrin commented Jun 7, 2023

This closes #1019

Output log with feature activated

Scan complete: 85 total, 2 nukeable, 83 filtered.

Do you really want to nuke these resources on the account with the ID xxx and the alias 'xxxx'?
Do you want to continue? Enter account alias to continue.
> 

global - CloudFrontOriginAccessControl - [ID: "E1W4QQOY6HOTWH"] - failed
global - CloudFrontDistribution - E39OUKF90IO5FJ - [LastModifiedTime: "2023-06-07T14:25:53Z"] - triggered remove

Removal requested: 1 waiting, 1 failed, 83 skipped, 0 finished

global - CloudFrontOriginAccessControl - [ID: "E1W4QQOY6HOTWH"] - removed
global - CloudFrontDistribution - E39OUKF90IO5FJ - [LastModifiedTime: "2023-06-07T14:25:53Z"] - waiting

Removal requested: 1 waiting, 0 failed, 83 skipped, 1 finished

global - CloudFrontDistribution - E39OUKF90IO5FJ - [LastModifiedTime: "2023-06-07T14:25:53Z"] - removed

Removal requested: 0 waiting, 0 failed, 83 skipped, 2 finished

Nuke complete: 0 failed, 83 skipped, 2 finished.

@npellegrin npellegrin requested a review from a team as a code owner June 7, 2023 15:20
@der-eismann
Copy link
Member

Similar to #1031 - the outer for loop doesn't really make sense to me, also the formatting is off here (spaces instead of tabs).

@npellegrin
Copy link
Contributor Author

Similar to #1031 - the outer for loop doesn't really make sense to me, also the formatting is off here (spaces instead of tabs).

Same as #1031 I forgot the pagination. I pushed a fix with pagination and go fmt.

@der-eismann der-eismann merged commit dc13c25 into rebuy-de:main Jun 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CloudFront Origin Access Control are not supported
3 participants