Add CloudFront Function (#1027) #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
der-eismann
reviewed
Jun 26, 2023
resources/cloudfront-function.go
Outdated
Comment on lines
23
to
44
| for { | ||
| resp, err := svc.ListFunctions(nil) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| for _, item := range resp.FunctionList.Items { | ||
| resources = append(resources, &CloudFrontFunction{ | ||
| svc: svc, | ||
| name: item.Name, | ||
| stage: item.FunctionMetadata.Stage, | ||
| }) | ||
| } | ||
| return resources, nil | ||
| } |
There was a problem hiding this comment.
Not sure if I missed anything, but this loop doesn't really make sense if you return after the first execution. Are you missing the actual pagination?
There was a problem hiding this comment.
You are right, I started implementing the pagination but fogot to actually add it on the way... I pushed an update adding it :)
der-eismann
approved these changes
Jun 27, 2023
bjoernhaeuser
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1027
Output with feature activated