[dx] Add --only-suffix to filter files by suffixes #6647
Conversation
TomasVotruba
force-pushed
the
tv-only-suffix
branch
from
a097ca7 to
477f569
Compare
| @@ -70,7 +74,7 @@ function (string $file): bool { | |||
|
|
|||
| // filtering files in directories collection | |||
| $directories = $this->fileAndDirectoryFilter->filterDirectories($filesAndDirectories); | |||
| $filteredFilePathsInDirectories = $this->findInDirectories($directories, $suffixes, $sortByName); | |||
| $filteredFilePathsInDirectories = $this->findInDirectories($directories, $suffixes, $sortByName, $onlySuffix); | |||
There was a problem hiding this comment.
This should check on $filteredFilePaths variable as well.
I am currently on mobile, i will check when I back to PC.
There was a problem hiding this comment.
I don't think that's necessary, as explicit files should be always used. That's the behavior I'd expect :)
There was a problem hiding this comment.
The files can be registered via withPaths(), which means unrelated to the --only-suffix use, show invalid expectation, eg --only-suffix=controllers, but rector.php and .php_cs_fixer.php also changed.
It should either check for both $filteredFilePaths and $filteredFilePathsInDirectories, or filter in final collection files result.
I will create new PR with what I mean.
There was a problem hiding this comment.
see PR:
for include other files unrelated to the --ony-suffix in the configration of paths provided.
Closes rectorphp/rector#8959