Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DX] Filter on files as well with --only-suffix #6648

Merged
merged 7 commits into from
Jan 5, 2025

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Jan 5, 2025

@TomasVotruba here also filter files in the list of withPaths(), provided other unrelated files with different suffix in config, it cause error:

There was 1 failure:

1) Rector\Tests\FileSystem\FilesFinder\FilesFinderTest::testFilterBySuffix
Failed asserting that actual size 2 matches expected size 1.

Ref #6647 (review)

@samsonasik
Copy link
Member Author

Fixed 🎉

@TomasVotruba TomasVotruba merged commit 1d078fa into main Jan 5, 2025
41 checks passed
@TomasVotruba TomasVotruba deleted the filter-on-files-as-well branch January 5, 2025 12:49
@TomasVotruba
Copy link
Member

Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants