Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixture for UnderscoreToCamelCaseLocalVariableNameRector #5716

Closed
wants to merge 1 commit into from
Closed

Fixture for UnderscoreToCamelCaseLocalVariableNameRector #5716

wants to merge 1 commit into from

Conversation

sanmai
Copy link
Contributor

@sanmai sanmai commented Mar 1, 2021

See #5715

$ php vendor/bin/phpunit  rules/naming/tests/Rector/Variable/UnderscoreToCamelCaseLocalVariableNameRector/
PHPUnit 9.5.2 by Sebastian Bergmann and contributors.

....................F                                             21 / 21 (100%)

Time: 00:05.459, Memory: 116.50 MB

There was 1 failure:

1) Rector\Naming\Tests\Rector\Variable\UnderscoreToCamelCaseLocalVariableNameRector\UnderscoreToCamelCaseLocalVariableNameRectorTest::test with data set #20 (Symplify\SmartFileSystem\SmartFileInfo Object (...))
rules/naming/tests/Rector/Variable/UnderscoreToCamelCaseLocalVariableNameRector/Fixture/do_not_overwrite_existing_variables.php.inc
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
 {
     public function foo()
     {
-       $foo_bar = 4;
+       $fooBar = 4;
        $fooBar = 2;
 
        $testExample = 5;
-       $test_example = 7;
+       $testExample = 7;
     }
 }

packages/testing/src/PHPUnit/AbstractRectorTestCase.php:319
packages/testing/src/PHPUnit/AbstractRectorTestCase.php:178
rules/naming/tests/Rector/Variable/UnderscoreToCamelCaseLocalVariableNameRector/UnderscoreToCamelCaseLocalVariableNameRectorTest.php:19

@samsonasik
Copy link
Member

@sanmai I cherry-picked your commit at PR #5718

TomasVotruba pushed a commit that referenced this pull request Mar 1, 2021
…in next and previous assign variable (#5718)

* Fixture for UnderscoreToCamelCaseLocalVariableNameRector

See #5715

* try

* fixture

* Closes #5716 Fixes #5715

* final touch

* [ci-review] Rector Rectify

Co-authored-by: Alexey Kopytko <alexey@kopytko.com>
Co-authored-by: kaizen-ci <info@kaizen-ci.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants