Incorrect behavior of UnderscoreToCamelCaseLocalVariableNameRector

[sanmai]

Bug Report

Subject	Details
Rector version	last dev-master
Installed as	composer dependency

Minimal PHP Code Causing Issue

See https://getrector.org/demo/34fcf41f-eef0-4ff3-aad9-ce6bf3abfbb1

<?php

final class DoNotOverwriteExistingVariables
{
    public function foo()
    {
       $foo_bar = 4;
       $fooBar = 2;

       $testExample = 5;
       $test_example = 7;
    }
}

Diff:

     public function foo()
     {
-       $foo_bar = 4;
+       $fooBar = 4;
        $fooBar = 2;
 
        $testExample = 5;
-       $test_example = 7;
+       $testExample = 7;
     }

Responsible rules

• UnderscoreToCamelCaseLocalVariableNameRector

Expected Behavior

Rector should not rename variables if there's another variable with the same name in current scope. Otherwise put, this example should not be changed at all.

[TomasVotruba]

Thank you for your report and demo link!

Could you send a failing test case in a pull-request, so we have it covered in Rector?
Here is step by step tutorial how to add it: https://github.com/rectorphp/rector/blob/master/docs/how_to_add_test_for_rector_rule.md

[sanmai]

Sure thing #5716