Add failing test fixture for UnderscoreToCamelCaseLocalVariableNameRector #5748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctor # Failing Test for UnderscoreToCamelCaseLocalVariableNameRector Based on https://getrector.org/demo/754d498e-ac9d-4f72-9d8c-d695f340318b
|
Latest getrector.org may not up to date, so using getrector.org may not be accurate. Using failing test case like this is the way we can detect the bug. I think one by one is ok as that will be easier to review. If you can provide a patch too, please do, thank you. |
|
@samsonasik I tried to fix it, but it seems there is more than meets the eye. Could you look into this? |
|
@TomasVotruba yes, I tried as well, and it is very complex. I will try re-check on |
|
See #5750 (comment) |
TomasVotruba
added a commit
that referenced
this pull request
Mar 21, 2024
rectorphp/rector-src@da67bb9 Add boolean and support to RemoveDeadInstanceOfRector (#5748)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failing Test for UnderscoreToCamelCaseLocalVariableNameRector
Based on https://getrector.org/demo/754d498e-ac9d-4f72-9d8c-d695f340318b
Another addition to #5739 and #5715.
Shall we fix #5750 this once and for all, or shall I invent more cases?