Merge pull request #587 from recurly/sim-275-v3-v2019-10-10

Replace empty() with is_null()
recurly · Mar 4, 2021 · 75dc9d7 · 75dc9d7
2 parents ba18ac5 + b2ac288
commit 75dc9d7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/lib/recurly/recurly_resource.php b/lib/recurly/recurly_resource.php
@@ -100,7 +100,7 @@ public static function cast(object $data): \Recurly\RecurlyResource
     {
         $klass = new static();
         foreach ($data as $key => $value) {
-            if (empty($value)) {
+            if (is_null($value)) {
                 continue;
             }
 

diff --git a/tests/RecurlyResource_Test.php b/tests/RecurlyResource_Test.php
@@ -21,6 +21,7 @@ public function testUnknownPropertyError(): void
     public function testFromJsonValidResource(): void
     {
         $test_resource = (object)[
+            "id" => "0",
             "object" => "test_resource",
             "name" => "test-resource",
             "single_child" => (object)[
@@ -45,6 +46,7 @@ public function testFromJsonValidResource(): void
         {
             $this->assertInstanceOf(\Recurly\Resources\TestResource::class, $resource);
         }
+        $this->assertEquals($result->getId(), 0);
     }
 
     public function testFromJsonNullArray(): void