Replace empty() with is_null() #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joannasese
force-pushed
the
sim-275-v3-v2019-10-10
branch
from
9324607 to
0b40316
Compare
tests/RecurlyResource_Test.php
Outdated
| // accepts response object of decoded json | ||
| // returns RecurlyResource | ||
| { | ||
| $test_response_object = (object)array( |
There was a problem hiding this comment.
nit: use [] instead of array()
douglasmiller
added a commit
that referenced
this pull request
Mar 22, 2021
# Changelog ## [Unreleased](https://github.com/recurly/recurly-client-php/tree/HEAD) [Full Changelog](4.0.0...HEAD) **Merged pull requests:** - Generated Latest Changes for v2021-02-25 [\#595](#595) ([recurly-integrations](https://github.com/recurly-integrations)) - Sync updates not ported from 3.x client [\#590](#590) ([douglasmiller](https://github.com/douglasmiller)) - Replace empty\(\) with is\_null\(\) [\#588](#588) ([joannasese](https://github.com/joannasese)) - Replace empty\(\) with is\_null\(\) [\#587](#587) ([joannasese](https://github.com/joannasese))
Merged
recurly-integrations
pushed a commit
that referenced
this pull request
Apr 15, 2022
[Full Changelog](3.11.0...3.12.0) **Merged Pull Requests** - Generated Latest Changes for v2019-10-10 [#678](#678) ([recurly-integrations](https://github.com/recurly-integrations)) - Generated Latest Changes for v2019-10-10 [#669](#669) ([recurly-integrations](https://github.com/recurly-integrations)) - Generated Latest Changes for v2019-10-10 [#663](#663) ([recurly-integrations](https://github.com/recurly-integrations)) - Generated Latest Changes for v2019-10-10 [#656](#656) ([recurly-integrations](https://github.com/recurly-integrations)) - Generated Latest Changes for v2019-10-10 (Tax Inclusive Pricing) [#649](#649) ([recurly-integrations](https://github.com/recurly-integrations)) - Generated Latest Changes for v2019-10-10 (Account Hierarchy Invoice Rollup) [#646](#646) ([recurly-integrations](https://github.com/recurly-integrations)) - Generated Latest Changes for v2019-10-10 [#643](#643) ([recurly-integrations](https://github.com/recurly-integrations)) - Generated Latest Changes for v2019-10-10 [#640](#640) ([recurly-integrations](https://github.com/recurly-integrations)) - Generated Latest Changes for v2019-10-10 (Added new response to subscription change) [#634](#634) ([recurly-integrations](https://github.com/recurly-integrations)) - Generated Latest Changes for v2019-10-10 (Dunning Campaigns feature) [#631](#631) ([recurly-integrations](https://github.com/recurly-integrations)) - Generated Latest Changes for v2019-10-10 (get_preview_renewal) [#629](#629) ([recurly-integrations](https://github.com/recurly-integrations)) - Generated Latest Changes for v2019-10-10 [#626](#626) ([recurly-integrations](https://github.com/recurly-integrations)) - Generated Latest Changes for v2019-10-10 [#617](#617) ([recurly-integrations](https://github.com/recurly-integrations)) - Generated Latest Changes for v2019-10-10 [#608](#608) ([recurly-integrations](https://github.com/recurly-integrations)) - Replace empty() with is_null() [#587](#587) ([joannasese](https://github.com/joannasese))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses report where a subscription/plan with
unitAmountof zero will returnNULLwhen callinggetUnitAmount().empty()was too inclusive.