Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 5.3 Support and upgrade Travis to support HHVM #316

Merged
merged 2 commits into from
May 31, 2017
Merged

Remove 5.3 Support and upgrade Travis to support HHVM #316

merged 2 commits into from
May 31, 2017

Conversation

bhelx
Copy link
Contributor

@bhelx bhelx commented May 31, 2017

HHVM is no longer supported on Ubuntu Precise. This is needed to get the tests to run again.

@bhelx bhelx changed the title Change Travis linux distribution for HHVM Remove 5.3 Support and upgrade Travis to support HHVM May 31, 2017
@bhelx bhelx changed the base branch from master to api_version_2_6 May 31, 2017 21:54
drewish
drewish approved these changes May 31, 2017
View reviewed changes
Copy link

@drewish drewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool as http://php.net/eol.php explains it's been 2 years, 9 months since 5.3 was only EOLed.

@drewish drewish merged commit f21d918 into api_version_2_6 May 31, 2017
@drewish drewish deleted the get_hhvm_to_work_in_travis branch May 31, 2017 21:57
@bhelx bhelx mentioned this pull request Jun 2, 2017
Merged
@phpdave
Copy link

phpdave commented Jul 14, 2017

I noticed the travis file references "PHP 7". Are you running tests against PHP 7.0 and PHP 7.1? I want to make sure I run a PHP version you're supporting.

Just an FYI that PHP 5.6 PHP 7.0 and PHP 7.1 have active security support
http://php.net/supported-versions.php

@drewish
Copy link

drewish commented Jul 14, 2017

@phpdave yeah tests are running on 7 but i'm not 100% if travis picks up 7.0 or 7.1 to do that. we could add both explicitly. but yes, we are still testing against some of the older unsupported versions.

@bhelx
Copy link
Contributor Author

bhelx commented Jul 14, 2017

@phpdave I'm pretty sure we need to explicitly support it. The travis file shows version 7 which, having looked at it, is running 7.0. If travis supports it, I will add a PR for this now.

@bhelx
Copy link
Contributor Author

bhelx commented Jul 14, 2017

@phpdave @drewish #324

@bhelx bhelx added the V2 V2 Client label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewish drewish drewish approved these changes

Assignees
No one assigned
Labels
V2 V2 Client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bhelx @phpdave @drewish