Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Version 2.6 #317

Merged
merged 11 commits into from
Jun 2, 2017
Merged

API Version 2.6 #317

merged 11 commits into from
Jun 2, 2017

Conversation

bhelx
Copy link
Contributor

@bhelx bhelx commented Jun 2, 2017

bhelx and others added 10 commits March 28, 2017 12:09
Add trial requires billing info field and no billing info reason field
Remove 5.3 Support and upgrade Travis to support HHVM
The X-Records header was removed on all GET index endpoints. You must
now call HEAD explicitly to get the header and thus the count.
@bhelx bhelx requested a review from drewish June 2, 2017 20:59
README.md Outdated
@@ -14,7 +14,7 @@ be careful when upgrading.

###cURL and OpenSSL
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should put a space in here

Copy link

@drewish drewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny nit

CHANGELOG.md Outdated
There are a few breaking changes this release.

1. PHP 5.3 is no longer officially supported and we no longer run tests against it.
2. To speed up your listing requests we're no longer automatically computing the record counts for each requests (`X-Records` header). For our larger sites this could halve the response time. If you still need a count it will be computed with a separate request. From now on, when you call Pager#count, it will send a HEAD request to the server. Ensure you aren't calling that method in places where you expect the value
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "request's"

Copy link

@drewish drewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

away we go

@drewish drewish merged commit 5bb1785 into master Jun 2, 2017
@drewish drewish deleted the api_version_2_6 branch June 2, 2017 22:45
@bhelx bhelx added the V2 V2 Client label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V2 V2 Client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants