Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that path parameters are not empty strings #494

Merged
merged 1 commit into from
May 4, 2020

Conversation

douglasmiller
Copy link
Contributor

Adding a validation method that will ensure that path parameters are not empty strings to address issues where a get_* operation (/resources/{resource_id}) does not get handled by the API as a list_* operations (/resources/).

Copy link
Contributor

@bhelx bhelx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bhelx bhelx merged commit eff4ea8 into master May 4, 2020
@bhelx bhelx deleted the validate-path-parameters branch May 4, 2020 16:54
douglasmiller added a commit that referenced this pull request May 6, 2020
# Changelog

## [Unreleased](https://github.com/recurly/recurly-client-php/tree/HEAD)

[Full Changelog](3.1.0...HEAD)

**Fixed bugs:**

- Parsing 'false' as null inside the v3 API [\#495](#495)

**Merged pull requests:**

- Make returns nullable [\#496](#496) ([bhelx](https://github.com/bhelx))
- Ensure that path parameters are not empty strings [\#494](#494) ([douglasmiller](https://github.com/douglasmiller))
@douglasmiller douglasmiller mentioned this pull request May 6, 2020
@joannasese joannasese changed the title Ensure that path parameters are not empty strings [WIP] Ensure that path parameters are not empty strings May 12, 2020
@joannasese joannasese changed the title [WIP] Ensure that path parameters are not empty strings Ensure that path parameters are not empty strings May 12, 2020
@joannasese joannasese added the V3 v2019-10-10 Client label Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V3 v2019-10-10 Client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants