Use helper method to safeguard against empty path parameters #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joannasese
changed the title
joannasese
force-pushed
the
validate-path-parameters
branch
from
ecaaac0
to
592245c
Compare
joannasese
force-pushed
the
validate-path-parameters
branch
from
592245c
to
1a60bb9
Compare
joannasese
changed the title
bhelx
reviewed
May 13, 2020
bhelx
reviewed
May 13, 2020
joannasese
force-pushed
the
validate-path-parameters
branch
2 times, most recently
from
b984e23
to
5b81e5a
Compare
joannasese
force-pushed
the
validate-path-parameters
branch
from
5b81e5a
to
f071e86
Compare
bhelx
reviewed
May 15, 2020
bhelx
reviewed
May 15, 2020
bhelx
reviewed
May 15, 2020
bhelx
reviewed
May 15, 2020
bhelx
reviewed
May 15, 2020
joannasese
force-pushed
the
validate-path-parameters
branch
from
486ba48
to
c9d8d82
Compare
joannasese
force-pushed
the
validate-path-parameters
branch
from
c9d8d82
to
39a6d44
Compare
bhelx
reviewed
May 15, 2020
bhelx
reviewed
May 15, 2020
- Build helper function to encode resource codes for URI - Isolate addition of URI forward slashes to within helper function - Safeguard against empty resource codes passed in as params
joannasese
force-pushed
the
validate-path-parameters
branch
from
aab619b
to
df49022
Compare
bhelx
reviewed
Jun 12, 2020
bhelx
approved these changes
Jun 13, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses same issue fixed in V3: #494
Adding a helper method to prevent empty strings from being passed in as accepted path parameters for all applicable GET requests.
Example:
$item = Recurly_Item::get("")would return<Recurly_ItemList[href=/items/]>. This occurred becauseuri = 'items/'instead ofuri = 'items/{item_code}'. Helper method throws an error when resource code is empty.