Add ramp pricing feature to plans #700
Conversation
Smolations
force-pushed
the
add-ramp-pricing-feature-to-plans
branch
9 times, most recently
from
cd50190
to
f62a0aa
Compare
- implements ramp interval features for plans - adds specs for new ramp intervals feature - does some other refactoring to harden tests - backfills some missing specs Co-authored-by: danilocandido <dcandido@recurly.com>
Smolations
force-pushed
the
add-ramp-pricing-feature-to-plans
branch
from
018bc62
to
50bbe55
Compare
| @@ -83,8 +117,36 @@ public function testUpdateXml() { | |||
| $plan->dunning_campaign_id = '1234abcd'; | |||
|
|
|||
| $this->assertEquals( | |||
| "<?xml version=\"1.0\"?>\n<plan><plan_code>platinum</plan_code><name>Platinum Plan</name><unit_amount_in_cents><USD>1500</USD><EUR>1200</EUR></unit_amount_in_cents><setup_fee_in_cents><USD>500</USD><EUR>500</EUR></setup_fee_in_cents><total_billing_cycles nil=\"nil\"></total_billing_cycles><tax_exempt>false</tax_exempt><tax_code>fake-tax-code</tax_code><trial_requires_billing_info>false</trial_requires_billing_info><dunning_campaign_id>1234abcd</dunning_campaign_id></plan>\n", | |||
| "<?xml version=\"1.0\"?>\n<plan><dunning_campaign_id>1234abcd</dunning_campaign_id><name>Platinum Plan</name><plan_code>platinum</plan_code><setup_fee_in_cents><USD>500</USD><EUR>500</EUR></setup_fee_in_cents><tax_code>fake-tax-code</tax_code><tax_exempt>false</tax_exempt><total_billing_cycles nil=\"nil\"></total_billing_cycles><trial_requires_billing_info>false</trial_requires_billing_info><unit_amount_in_cents><USD>1500</USD><EUR>1200</EUR></unit_amount_in_cents></plan>\n", | |||
There was a problem hiding this comment.
i think if you use assertXmlStringEqualsXmlString you can compare if that xml is equal to plan xml and indent it to be more readable
There was a problem hiding this comment.
Yea that definitely seems like it would be better. However, it has been "decreed" that no more refactors take place (though I'm not sure how that's gonna be possible 😅) so since I was just fixing a previously broken test I didn't spend any additional time. However, my upcoming work might touch/break some tests that are similar here and I think I could make it better. We shall see!
| protected function updateErrorAttributes() | ||
| { | ||
| if (sizeof($this->_errors) > 0) { | ||
| for ($i = sizeof($this->_errors) - 1; $i >= 0; $i--) { |
There was a problem hiding this comment.
maybe $i could be $errorIndex?
There was a problem hiding this comment.
If I'm reading this right, $i represents the size of that array, yea? This was just a method I had shuffled around so I didn't actually write this code.. 😅
EDIT: Didn't read it closely enough. You're right, it represents an index for the loop.. 🙈
[Full Changelog](2.12.25...2.12.26) **Merged Pull Requests** - Add Ramp Pricing Feature to Subscriptions [#703](#703) ([Smolations](https://github.com/Smolations)) - Add ramp pricing feature to plans [#700](#700) ([Smolations](https://github.com/Smolations))
The Ramp Pricing feature is supported as a result of this change. Also, some refactoring was done to start curbing bad patterns and separate code out into logical chunks:
CONTRIBUTING.mdfile was updated to provide a bit more direction for developers looking to add to this library with no prior experience.XmlToolsclass was created with the aim of being a purely static class to handle individual XML operations. Much of theRecurly_Resourcecode was moved here.XmlDoctrait was created with the aim of being adding the ability to represent any class as an XML node/document. It includes mechanisms to track the possible child nodes of a class as well as handle the conversion from the object into an XML document string.Recurly_BaseandRecurly_Resourcewere overhauled to accommodate these new tools, moving in a more common sense direction around model relationships in this library (e.g. a "resource" can be directly fetched from the server and a "node" (or doc) simply needs to be represented as XML).To see how the new ramp pricing feature is utilized, see the spec tests added in this change.