-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ramp Pricing Feature to Subscriptions #703
Conversation
c5e9803
to
a51e2e6
Compare
@@ -122,31 +146,14 @@ public function testUpdateXml() { | |||
); | |||
} | |||
|
|||
public function testUpdateWithRampsXml() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this since it just tests serialization which is covered in the testCreateWithRampsXml
test case.
@@ -3,6 +3,51 @@ Content-Type: application/xml; charset=utf-8 | |||
|
|||
<?xml version="1.0" encoding="UTF-8"?> | |||
<subscriptions type="array"> | |||
<subscription href="https://api.recurly.com/v2/subscriptions/32558dd8a07smo471fbe6642d3a422f4"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For posterity. 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! Loved the refactor for readable XML and new Recurly_RampInterval
class to implement nodeToObject
and attention to details in the commentary. Readable, maintainable PHP. Who knew?
a51e2e6
to
3d3f7b1
Compare
[Full Changelog](2.12.25...2.12.26) **Merged Pull Requests** - Add Ramp Pricing Feature to Subscriptions [#703](#703) ([Smolations](https://github.com/Smolations)) - Add ramp pricing feature to plans [#700](#700) ([Smolations](https://github.com/Smolations))
Adds the ramp pricing feature to subscriptions.