Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ramp Pricing Feature to Subscriptions #703

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

Smolations
Copy link

Adds the ramp pricing feature to subscriptions.

@Smolations Smolations force-pushed the add-ramp-pricing-feature-to-subs branch 2 times, most recently from c5e9803 to a51e2e6 Compare August 8, 2022 20:45
@@ -122,31 +146,14 @@ public function testUpdateXml() {
);
}

public function testUpdateWithRampsXml() {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this since it just tests serialization which is covered in the testCreateWithRampsXml test case.

@@ -3,6 +3,51 @@ Content-Type: application/xml; charset=utf-8

<?xml version="1.0" encoding="UTF-8"?>
<subscriptions type="array">
<subscription href="https://api.recurly.com/v2/subscriptions/32558dd8a07smo471fbe6642d3a422f4">
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For posterity. 😁

@Smolations Smolations marked this pull request as ready for review August 8, 2022 21:10
Copy link

@mwlang mwlang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Loved the refactor for readable XML and new Recurly_RampInterval class to implement nodeToObject and attention to details in the commentary. Readable, maintainable PHP. Who knew?

@danilocandido danilocandido force-pushed the add-ramp-pricing-feature-to-subs branch from a51e2e6 to 3d3f7b1 Compare August 12, 2022 15:25
@csampson csampson merged commit 0396b37 into v2 Aug 12, 2022
@csampson csampson deleted the add-ramp-pricing-feature-to-subs branch August 12, 2022 18:11
recurly-integrations pushed a commit that referenced this pull request Aug 24, 2022
[Full Changelog](2.12.25...2.12.26)

**Merged Pull Requests**

- Add Ramp Pricing Feature to Subscriptions [#703](#703) ([Smolations](https://github.com/Smolations))
- Add ramp pricing feature to plans [#700](#700) ([Smolations](https://github.com/Smolations))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants