Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from opendatahub-io:main #359

Closed
wants to merge 24 commits into from

Conversation

pull[bot]
Copy link

@pull pull bot commented Aug 14, 2024

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

Copy link

openshift-ci bot commented Aug 14, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jiridanek for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Aug 14, 2024

Hi @pull[bot]. Thanks for your PR.

I'm waiting for a red-hat-data-services member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

caponetto and others added 7 commits August 15, 2024 09:35
…ased image from an existing one (#672)

* Add script to automate the creation of a new Python-based image from an existing one

* Add type annotations to function args

* Add missing folders to blocklist

* Removing redundant comment

* Use dataclass in the Args class

* Use context manager for logged_execution

* Set encoding prop on subprocess.run

* Improve log level help message

* Return non-zero code for non-happy scenarios

* Add type annotations to function return

* Final adjustments

* Code review request
RHOAIENG-11300: Improve the library upgrade script for alternative sources
Fix reference to quay.io/repository/opendatahub on README file
Signed-off-by: codeflare-machine-account <138894154+codeflare-machine-account@users.noreply.github.com>
* Add images based on python 3.11

* Apply #656 to Python 3.11 images

* Fix expected TF vesion on the test file

* Fix labels for Python 3.11

* Apply #652 to Python 3.11 images

* Update lock to fix debugpy package version

* Apply #635 to Python 3.11 images

* Replace 3-9 -> 3-11 leftovers

* Fix runtime rocm image name according to openshift/release

* Apply #667 to Python 3.11 images

* Adapt test code for Python 3.11 images
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

dibryant and others added 10 commits August 16, 2024 12:33
…058789

[Codeflare Action] Update notebook's pipfile to sync with Codeflare-SDK release 0.19.1
Updated image manifests with AMD images for pytorch and tensorflow
Recently the kustomize test started to fail for us since the kustomize
version 5.4 introduced some breaking changes for which we will need to
update our manifests to be compatible. This work will be tracked in [1].
In the meantime, we should pin kustomize version in our GHA to the
version that is used by the opendatahub-operator in runtime [2].

[1] https://issues.redhat.com/browse/RHOAIENG-11679
[2] https://github.com/red-hat-data-services/rhods-operator/blob/rhoai-2.12/go.mod#L30-L31
[GHA] Pin kustomize version we use in our test to the particular version
Update the codeflare-sdk version in manifest for the relevant images
Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
Update runtime updater workflow to search for the  new ROCm runtimes
openshift-merge-bot bot and others added 3 commits August 22, 2024 07:49
Use the correct way of ROCm brand in user facing content
RHOAIENG-11090: Create a script to automate multiple library upgrades
@atheo89
Copy link
Member

atheo89 commented Aug 29, 2024

Closing this in favor #364

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants