[release-4.10] Bug 2098562: rbd: create token and use it for vault SA #99
Conversation
create the token if kubernetes version in 1.24+ and use it for vault sa. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com> Signed-off-by: Rakshith R <rar@redhat.com> (cherry picked from commit 7a2dd4c)
|
@openshift-cherrypick-robot: Bugzilla bug 2094856 has been cloned as Bugzilla bug 2098562. Retitling PR to link against new bug. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
changed the title
|
@openshift-cherrypick-robot: This pull request references Bugzilla bug 2098562, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold |
|
/bugzilla refresh |
|
@Rakshith-R: This pull request references Bugzilla bug 2098562, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci
bot
added
bugzilla/valid-bug
and removed
do-not-merge/hold
bugzilla/invalid-bug
labels
|
@Rakshith-R: This pull request references Bugzilla bug 2098562, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: keesturam. Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: agarwal-mudit, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: Bugzilla bug 2098562 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…tSA.createToken Pull-Request #99 backported a commit that applies cleanly, but causes a build failure: internal/kms/vault_sa.go:313:12: kms.createToken undefined (type *VaultTenantSA has no field or method createToken) internal/kms/vault_sa.go:344:12: undefined: vaultTenantSA In recent versions, `vaultTenantSA` is used, but release-4.10 is stuck on the old naming of `VaultTenantSA`. The unexporting was done in upstream ceph#2750, which includes more changes than what we want in a backport. Signed-off-by: Niels de Vos <ndevos@redhat.com>
This is an automated cherry-pick of #98
/assign Rakshith-R