Initialize tracing export code to run earlier in the startup process. (…

…#983) This avoids a race-condition with our gevent patching. Co-authored-by: Trevor Riles <trevor@reddit.com>
reddit · Sep 16, 2024 · c1acbd0 · c1acbd0
1 parent e452393
commit c1acbd0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/baseplate/server/__init__.py b/baseplate/server/__init__.py
@@ -331,7 +331,6 @@ def load_app_and_run_server() -> None:
         logger.info("Metrics are not configured, Prometheus metrics will not be exported.")
 
     configure_logging(config, args.debug)
-    configure_tracing()
 
     app = make_app(config.app)
     listener = make_listener(args.bind)

diff --git a/bin/baseplate-serve b/bin/baseplate-serve
@@ -21,6 +21,7 @@ except ImportError:
     pass
 
 
-from baseplate.server import load_app_and_run_server
+from baseplate.server import configure_tracing, load_app_and_run_server
 
+configure_tracing()
 load_app_and_run_server()