Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize tracing export code to run earlier in the startup process. #983

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

trevorriles
Copy link
Contributor

@trevorriles trevorriles commented Sep 13, 2024

This avoids a race-condition with our gevent patching.

Resolves the error that looks like:

Traceback (most recent call last):
  File "src/gevent/_abstract_linkable.py", line 287, in gevent._gevent_c_abstract_linkable.AbstractLinkable._notify_links
  File "src/gevent/_abstract_linkable.py", line 333, in gevent._gevent_c_abstract_linkable.AbstractLinkable._notify_links
AssertionError: (None, <callback at 0x7f72a5936040 args=([],)>)
2024-05-01T14:26:07Z <callback at 0x7f72a5936040 args=([],)> failed with AssertionError

Closes #

💸 TL;DR

📜 Details

Design Doc

Jira

🧪 Testing Steps / Validation

✅ Checks

  • CI tests (if present) are passing
  • Adheres to code style for repo
  • Contributor License Agreement (CLA) completed if not a Reddit employee

This avoids a race-condition with our gevent patching.
@trevorriles trevorriles requested a review from a team as a code owner September 13, 2024 18:40
@trevorriles trevorriles merged commit c1acbd0 into develop Sep 16, 2024
5 checks passed
@trevorriles trevorriles deleted the fix-tracing-init branch September 16, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants