Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize tracing export code to run earlier in the startup process. #983

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Initialize tracing export code to run earlier in the startup process. #983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f392f6
Initialize tracing export code to run earlier in the startup process.
Sep 13, 2024
fea5ac8
Merge branch 'develop' into fix-tracing-init
trevorriles Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion baseplate/server/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,6 @@ def load_app_and_run_server() -> None:
logger.info("Metrics are not configured, Prometheus metrics will not be exported.")

configure_logging(config, args.debug)
configure_tracing()

app = make_app(config.app)
listener = make_listener(args.bind)
Expand Down
3 changes: 2 additions & 1 deletion bin/baseplate-serve
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ except ImportError:
pass


from baseplate.server import load_app_and_run_server
from baseplate.server import configure_tracing, load_app_and_run_server

configure_tracing()
load_app_and_run_server()